Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [Bug report]: weird syntax after creating a play in typescript #33

Closed
1 task done
Angryman18 opened this issue Jan 29, 2023 · 10 comments 路 Fixed by #35
Closed
1 task done

馃悰 [Bug report]: weird syntax after creating a play in typescript #33

Angryman18 opened this issue Jan 29, 2023 · 10 comments 路 Fixed by #35
Assignees
Labels
bug Something isn't working

Comments

@Angryman18
Copy link
Member

Descrcibe the bug?

found the below syntax after creating a typescript play and its throwing error on browser

Steps to reproduce the bug?

creating a play in typescirpt will have the error

Expected behavior

there should not be any error after creating a play in typescript

Desktop (Please provide your system information)

Ubuntu version 22.04

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

Screenshot from 2023-01-29 20-33-19

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Angryman18 Angryman18 added the bug Something isn't working label Jan 29, 2023
@atapas
Copy link
Member

atapas commented Jan 29, 2023

Will you fix it?

@surya-situ
Copy link
Contributor

I would like to fix it , but after installing npm when I did npm start it through around 19009 problems .
( it is going to be my first contribution after many failed attempt).

@atapas
Copy link
Member

atapas commented Jan 29, 2023

I would like to fix it , but after installing npm when I did npm start it through around 19009 problems .

( it is going to be my first contribution after many failed attempt).

Sure. Can you make sure, you can run it locally without error? You may have to follow the readme for the formatting and linting. I've assigned the issue to you.

We need this fix sooner.

@atapas atapas assigned Angryman18 and surya-situ and unassigned Angryman18 Jan 29, 2023
@atapas
Copy link
Member

atapas commented Jan 30, 2023

Looping in @koustov

@koustov
Copy link
Member

koustov commented Jan 30, 2023

[HINT] @surya-situ , you need to replace the import './styles.{{style}}'; in component_tsx.tmpl (or component_ts.tmpl) with import './styles.%PLAY_STYLE%';

@atapas
Copy link
Member

atapas commented Jan 30, 2023

[HINT] @surya-situ , you need to replace the import './styles.{{style}}'; in component_tsx.tmpl (or component_ts.tmpl) with import './styles.%PLAY_STYLE%';

@surya-situ can you please roll these changes in the next few hours? As we are on the edge to start our next event, this fix need to be fixed and tested soon.

@surya-situ
Copy link
Contributor

I'm working on it

@surya-situ
Copy link
Contributor

Assign it to someone I'm not able to fix it.

@koustov koustov transferred this issue from reactplay/react-play Jan 30, 2023
@koustov
Copy link
Member

koustov commented Jan 30, 2023

Assign it to someone I'm not able to fix it.

Actually @surya-situ , this issue is not with react-play repo. It belongs to crate-react-play repo. You might want to give it another try

@surya-situ
Copy link
Contributor

surya-situ commented Jan 30, 2023

I have push the code can you review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants