Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature request]: Filter Plays by Language #161

Closed
atapas opened this issue May 8, 2022 · 7 comments · Fixed by #182
Closed

✨ [Feature request]: Filter Plays by Language #161

atapas opened this issue May 8, 2022 · 7 comments · Fixed by #182
Assignees
Labels
good first issue New-contributor friendly

Comments

@atapas
Copy link
Member

atapas commented May 8, 2022

Is your feature request related to a problem? Please describe.
As we support both JS and TS BASED plays, provide ability to filter based on language.

Describe the solution you'd like
Add one more filter option for language with the existing filters.

Describe alternatives you've considered
None

Additional context
None

@atapas atapas added the good first issue New-contributor friendly label May 8, 2022
@hasnainmakada-99
Copy link
Contributor

Tapas sir can you tell me in which file we have to implement this functionality ?

@atapas
Copy link
Member Author

atapas commented May 14, 2022

Tapas sir can you tell me in which file we have to implement this functionality ?

I can but you first debug to find out urself and you will learn. I'm there always to tell you at the end 🙌

@hasnainmakada-99
Copy link
Contributor

Ok sir let me look into the code

@hasnainmakada-99
Copy link
Contributor

@atapas sir, I've looked into the code base and there are going to be many changes if we want to implement this functionality, there should be someone who knows react very well, because I can understand the issue but I will not be able to implement it in react

@atapas
Copy link
Member Author

atapas commented May 16, 2022

@atapas sir, I've looked into the code base and there are going to be many changes if we want to implement this functionality, there should be someone who knows react very well, because I can understand the issue but I will not be able to implement it in react

No worries @hasnainmakada-99

I shall take it up and fix it today. Please feel free to ask me questions based on the fix. I will be happy to answer so that you will also be aware of that portion of the code area.

@atapas atapas self-assigned this May 16, 2022
@hasnainmakada-99
Copy link
Contributor

Sure @atapas sir

@atapas atapas mentioned this issue May 16, 2022
4 tasks
@atapas atapas linked a pull request May 16, 2022 that will close this issue
4 tasks
@atapas
Copy link
Member Author

atapas commented May 16, 2022

hasnainmakada-99

Here you go: #182 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New-contributor friendly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants