Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug report]: Normalize the backend API calls #353

Closed
atapas opened this issue Jun 26, 2022 · 7 comments
Closed

🐛 [Bug report]: Normalize the backend API calls #353

atapas opened this issue Jun 26, 2022 · 7 comments
Assignees
Labels
bug Something isn't working stale

Comments

@atapas
Copy link
Member

atapas commented Jun 26, 2022

Describe the bug

The Home page makes the call to list all the plays but we do not use it in the Home page. Ideally,

  • Home page should make the "Featured" play call
  • The play list page should make the all plays call with minimalistic data required for the thumbnails.
  • Each of the play details should retrieve all required data for a play.
@atapas atapas added the bug Something isn't working label Jun 26, 2022
@6km
Copy link
Member

6km commented Jul 19, 2022

can I help with this issue?

@Angryman18
Copy link
Member

Angryman18 commented Jul 19, 2022

i guess it is being managed by #371

@atapas atapas assigned koustov and unassigned Angryman18 Jul 19, 2022
@Angryman18
Copy link
Member

Screencast.from.25-07-22.07.31.38.PM.IST.webm

this issue isnt solved i guess.

@koustov
Copy link
Member

koustov commented Aug 2, 2022

Screencast.from.25-07-22.07.31.38.PM.IST.webm
this issue isnt solved i guess.

@Angryman18 , I didn't get the issue . Are you saying that, there shouldn't be any more API calls to list PLAYS once its done in /plays route? Please explain

@Angryman18
Copy link
Member

yes that was what i tried to show there. I think we dont make the call when user goes into a play but if user landing directly on a play only then we should me making the api call ?

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 25, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2022
@atapas atapas reopened this Sep 7, 2023
@atapas atapas removed the stale label Sep 7, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 26, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

4 participants