Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature request]: Change how contributors are displayed in the homepage #492

Closed
ammaaraslam opened this issue Aug 14, 2022 · 20 comments
Assignees
Labels

Comments

@ammaaraslam
Copy link
Member

Describe the solution you'd like

Currently the Contributors section in the homepage consists of only 29 contributors out of 39 (this is caused by the GitHub API's pagination system - each page returns only 30 items) and each contributor is represented inside a circle. Here are few features to be implemented on to the contributors section (suggested by @atapas).

  • Based on the number of contributions we make the circle bigger... more contributions more bigger circle. We get the contribution count already.
  • We show first 25 contributors on the page starting with the bigger (most contributions) to smaller circles (least contributions).
  • Then we show a link like "See more contributors" and that takes to the project's readme's contributor section where we show all the contributors.

This may encourage people to even contribute more make their circle bigger and even to appear on our home page.

@nobel10122025
Copy link

i would like to work on this :)

@yung-coder
Copy link
Contributor

I would like to work on it 🛠️

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 15, 2022
@yung-coder
Copy link
Contributor

Hey @atapas i will continue the work for the issue form tomorrow sorry for the delay i was just busy with my college exams..!

@github-actions github-actions bot removed the stale label Nov 19, 2022
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 20, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2022
@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Jan 19, 2023
@AbhiPatel10
Copy link
Contributor

Looks good or Should we make a consistency on bigger to smaller Circle?

image

@atapas
Copy link
Member

atapas commented Feb 10, 2023

Looks good or Should we make a consistency on bigger to smaller Circle?

image

Yes I like it. What's your logic?

@AbhiPatel10
Copy link
Contributor

I Use Switch case in One function and use that function in Style.

switch (true) {
case item >= 80:
contributionCircle = { height: '150px', width: '150px' };

    break;
  case item < 80 && item >= 50:
    contributionCircle = { height: '130px', width: '130px' };

    break;
  case item < 50 && item >= 30:
    contributionCircle = { height: '100px', width: '100px' };

    break;
  default:
    contributionCircle = { height: '50px', width: '50px' };
}

So Now we need to show only 25 contributors in Home page and made one Button for "See more contributors" and redirect to GitHub contributors ?

also please assign this task to me.

@6km
Copy link
Member

6km commented Feb 10, 2023

Yes I like it. What's your logic?

More Contributions = Bigger Circle 😃

@atapas
Copy link
Member

atapas commented Feb 10, 2023

I Use Switch case in One function and use that function in Style.

switch (true) { case item >= 80: contributionCircle = { height: '150px', width: '150px' };

    break;
  case item < 80 && item >= 50:
    contributionCircle = { height: '130px', width: '130px' };

    break;
  case item < 50 && item >= 30:
    contributionCircle = { height: '100px', width: '100px' };

    break;
  default:
    contributionCircle = { height: '50px', width: '50px' };
}

So Now we need to show only 25 contributors in Home page and made one Button for "See more contributors" and redirect to GitHub contributors ?

also please assign this task to me.

Great..

A few things:

  • These sizes must be responsive. so that on mobile, tab , and desktops they scale well.
  • We need to have a contributions page on the /contributors route to list them all in a card with
    photo, name, number of contributions

@AbhiPatel10
Copy link
Contributor

Okay, I'm working on it to improve that code and make it responsive across all devices.

Is there a specific design I should use for the contributor page, or can I make it however I see fit? 

@atapas
Copy link
Member

atapas commented Feb 10, 2023

Okay, I'm working on it to improve that code and make it responsive across all devices.

Is there a specific design I should use for the contributor page, or can I make it however I see fit?

Make it on Figrma or https://excalidraw.com/ and share the design first

@atapas
Copy link
Member

atapas commented Feb 10, 2023

Hey @yung-coder

I have added @AbhiPatel10 as assignee to this issue as he made some progress on it. If you had started on it or panning to contribute, you both can collaborate. In case you are not working/not panning to work on it, let me know.

@yung-coder
Copy link
Contributor

@atapas

Hey sure would love to collaborate and finish this task asap pitch me on discord @AbhiPatel10 let's get this done.

@AbhiPatel10
Copy link
Contributor

@yung-coder Thank you for collaborating; I have sent you the message on Discord.

@atapas
Copy link
Member

atapas commented Feb 12, 2023

@AbhiPatel10 @yung-coder

Please give me an idea of how the all contributors page may look like. Some basic design.

@AbhiPatel10
Copy link
Contributor

Sure sir working on it... Building basic design in Figma

@AbhiPatel10
Copy link
Contributor

Looks Good ? @atapas Sir

image

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Mar 17, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2023
@atapas atapas reopened this Sep 7, 2023
@atapas atapas removed the stale label Sep 7, 2023
Copy link

github-actions bot commented Nov 8, 2023

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants