Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next and previous button position change #12

Closed
chayancbnits opened this issue Aug 9, 2019 · 10 comments
Closed

next and previous button position change #12

chayancbnits opened this issue Aug 9, 2019 · 10 comments
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@chayancbnits
Copy link

Thanks for uploading this package.
next and previous button position change react-native-web-swiper

S

@oxyii oxyii self-assigned this Aug 10, 2019
@oxyii oxyii added help wanted Extra attention is needed question Further information is requested labels Aug 10, 2019
@oxyii
Copy link
Collaborator

oxyii commented Aug 10, 2019

@chayancbnits thanks for your report. Will you show dots in your case? You can override controlsWrapperStyle for now

@chayancbnits
Copy link
Author

Thanks for the reply to me also I am using "controlsWrapperStyle" when I wrote, "top: 0 " for the arraow button position in the middle of height, for this reason, the inner TouchableOpacity not clickable
Sc
.

@oxyii
Copy link
Collaborator

oxyii commented Aug 10, 2019

@chayancbnits controlsWrapperStyle must have height: 0 but prevButtonStyle and nextButtonStyle must have a height > 0. So, controls wrapper will not overlay other components. This is temporary solution. I hope swiper will be a part of react-native-elements soon and with totally rewrited props

@chayancbnits
Copy link
Author

@oxyii Thanks, Now it's clickable but I want to center of the height for direction arrows in both sides

Screenshot from 2019-08-10 23:59:49
.

@oxyii
Copy link
Collaborator

oxyii commented Aug 10, 2019

@chayancbnits This is really temporary solution snack

@oxyii oxyii closed this as completed Aug 10, 2019
@chayancbnits
Copy link
Author

@oxyii Thanks for supporting me, but in browser slider, the next button onClick event is absolutely working but not in android.

@oxyii
Copy link
Collaborator

oxyii commented Aug 10, 2019

@chayancbnits Please wait. I'll make v2.0 in a few hours

@oxyii oxyii reopened this Aug 10, 2019
@chayancbnits
Copy link
Author

@oxyii Thanks for the support, I am waiting for react-native-web-swiper V2.0

@oxyii oxyii mentioned this issue Aug 11, 2019
Merged
@oxyii
Copy link
Collaborator

oxyii commented Aug 11, 2019

@chayancbnits now you can upgrade to 2.0 and use something like this:

<Swiper
  controlsProps={{
    prevPos: 'left',
    nextPos: 'right',
    dotsPos: false,
    cellsContent: {
      'bottom-right': (
        <TouchableOpacity>
          <Text>Your Custom Touchable Component</Text>
        </TouchableOpacity>
      )
    }
  }}
>
...
</Swiper>

or you can continue to use touchable inside swiper slides

@oxyii
Copy link
Collaborator

oxyii commented Aug 11, 2019

@chayancbnits As I said, props totally rewrited. So, please take a look at updated README and see updated demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants