fix(Modal): use togglePortal on componentDidMount (#106)

reactstrap · Aug 19, 2016 · 942b24a · 942b24a
1 parent a358233
commit 942b24a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Modal.jsx b/src/Modal.jsx
@@ -31,7 +31,7 @@ class Modal extends React.Component {
 
   componentDidMount() {
     if (this.props.isOpen) {
-      this.show();
+      this.togglePortal();
     }
   }
 

diff --git a/test/Modal.spec.js b/test/Modal.spec.js
@@ -183,7 +183,7 @@ describe('Modal', () => {
 
     jasmine.clock().tick(300);
     expect(isOpen).toBe(true);
-    expect(Modal.prototype.togglePortal.calls.count()).toEqual(0);
+    expect(Modal.prototype.togglePortal.calls.count()).toEqual(1);
     expect(Modal.prototype.renderIntoSubtree.calls.count()).toEqual(1);
 
     wrapper.setProps({
@@ -192,7 +192,7 @@ describe('Modal', () => {
     jasmine.clock().tick(300);
 
     expect(isOpen).toBe(true);
-    expect(Modal.prototype.togglePortal.calls.count()).toEqual(0);
+    expect(Modal.prototype.togglePortal.calls.count()).toEqual(1);
     expect(Modal.prototype.renderIntoSubtree.calls.count()).toEqual(2);
 
     wrapper.unmount();