fix(DropDownItem): when href use a tag (#377)

fixes #367
reactstrap · Mar 31, 2017 · 96616af · 96616af
1 parent fe48e9e
commit 96616af
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/DropdownItem.js b/src/DropdownItem.js
@@ -76,6 +76,8 @@ class DropdownItem extends React.Component {
         Tag = 'h6';
       } else if (divider) {
         Tag = 'div';
+      } else if (props.href) {
+        Tag = 'a';
       }
     }
 

diff --git a/src/__tests__/DropdownItem.spec.js b/src/__tests__/DropdownItem.spec.js
@@ -46,6 +46,16 @@ describe('DropdownItem', () => {
     });
   });
 
+  describe('link (with href)', () => {
+    it('should render an anchor tag', () => {
+      const wrapper = mount(<DropdownItem href="#">GO!</DropdownItem>);
+
+      expect(wrapper.find('a').length).toBe(1);
+      expect(wrapper.find('a').hasClass('dropdown-item')).toBe(true);
+      expect(wrapper.text()).toBe('GO!');
+    });
+  });
+
   describe('onClick', () => {
     it('should not be called when disabled', () => {
       const e = { preventDefault: jasmine.createSpy('preventDefault') };