Skip to content

Commit

Permalink
fix(Popover): remove old arrow markup, correct enabled className
Browse files Browse the repository at this point in the history
  • Loading branch information
eddywashere committed Nov 28, 2016
1 parent d9e7621 commit b9d3ea7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/Popover.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ const defaultProps = {

const defaultTetherConfig = {
classPrefix: 'bs-tether',
classes: { element: 'popover', enabled: 'open' },
classes: {
element: false,
enabled: 'in'
},
constraints: [
{ to: 'scrollParent', attachment: 'together none' },
{ to: 'window', attachment: 'together none' }
Expand Down Expand Up @@ -63,7 +66,7 @@ class Popover extends React.Component {

return (
<TetherContent
arrow="popover"
className="popover"
tether={tetherConfig}
tetherRef={this.props.tetherRef}
isOpen={this.props.isOpen}
Expand Down
2 changes: 2 additions & 0 deletions src/__tests__/Popover.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ describe('Popover', () => {
expect(isOpen).toBe(false);

expect(wrapper.find(TetherContent).length).toBe(0);
expect(document.body.querySelectorAll('.popover.in').length).toBe(0);
expect(document.getElementsByClassName('popover').length).toBe(0);
expect(document.getElementsByClassName('popover-inner').length).toBe(0);
expect(document.getElementsByClassName('popover-title').length).toBe(0);
Expand All @@ -80,6 +81,7 @@ describe('Popover', () => {

expect(isOpen).toBe(true);
expect(wrapper.find(TetherContent).length).toBe(1);
expect(document.body.querySelectorAll('.popover.in').length).toBe(1);
expect(document.getElementsByClassName('popover').length).toBe(1);
expect(document.getElementsByClassName('popover-inner').length).toBe(1);
expect(document.getElementsByClassName('popover-title').length).toBe(1);
Expand Down

0 comments on commit b9d3ea7

Please sign in to comment.