feat(Tooltip): add tooltip accessibility #1012 #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSharpieOne
requested changes
May 17, 2018
src/Tooltip.js
Outdated
| @@ -156,6 +168,11 @@ class Tooltip extends React.Component { | |||
| addTargetEvents() { | |||
| this._target.addEventListener('mouseover', this.onMouseOverTooltip, true); | |||
| this._target.addEventListener('mouseout', this.onMouseLeaveTooltip, true); | |||
| this._target.addEventListener('keydown', this.onEscKeyDown, true); | |||
| this._target.addEventListener('focusin', this.handleFocus, true); | |||
There was a problem hiding this comment.
Because this calls the same method as focusout which just blindly toggles the tooltip, it can get into a bad state where focusin hides the toggle and focusout shows it. We probably want to explicitly show on focusin and hide on focusout
Also, this is more evident when using esc to close the tooltip and then tabbing away.
|
@TheSharpieOne Thanks for the explanation! |
…reactstrap into tooltip-accessibilty
TheSharpieOne
approved these changes
May 21, 2018
|
@TheSharpieOne Thanks! This is my first code contribution to open source. I encourage you to critique my PRs as I want to improve. Mind tagging me when you change the handles so I can see what you did? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds shows a tooltip on focus and hides it when out of focus. Also adds the ability to close tooltip using the escape key. Adds
role='tooltip'to the tooltip.