Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add innerRef to CustomInput (#1082) #1123

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Add innerRef to CustomInput (#1082) #1123

merged 1 commit into from
Jul 10, 2018

Conversation

Holi0317
Copy link
Contributor

I am not sure this API is good or not. We have 3 choices for the reference(s) for Custom Input:

  1. Set innerRef to input or select DOM element, like what Input Component do
  2. Set innerRef to top level element of CustomInput. Like div for type="file" and select for type="select"
  3. Add more props related to referencing to the component API and allow component consumers to get reference to any DOM component (wrapper div, label or input) they want.

@TheSharpieOne TheSharpieOne merged commit 418fdf8 into reactstrap:master Jul 10, 2018
juanmaguitar added a commit to juanmaguitar/reactstrap that referenced this pull request Jul 10, 2018
@juanmaguitar
Merge branch 'master' of github.com:reactstrap/reactstrap
2d67726 
* 'master' of github.com:reactstrap/reactstrap:
  feat(CustomInput) : add innerRef to CustomInput (reactstrap#1123)
  feat(Tooltip): allow additional arrow classNames (reactstrap#1119)
juanmaguitar added a commit to juanmaguitar/reactstrap that referenced this pull request Jul 10, 2018
@juanmaguitar
added reactstrap#1123 to CHANGELOG
84269e4
@juanmaguitar juanmaguitar mentioned this pull request Jul 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSharpieOne TheSharpieOne TheSharpieOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Holi0317 @TheSharpieOne