Select first element matching pressed key in dropdown (#1156) #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSharpieOne
requested changes
Aug 4, 2018
src/Dropdown.js
Outdated
| @@ -132,23 +132,32 @@ class Dropdown extends React.Component { | |||
| const disabledClass = mapToCssModules('disabled', this.props.cssModule); | |||
|
|
|||
| const items = container.querySelectorAll(`.${menuClass} .${itemClass}:not(.${disabledClass})`); | |||
| const char = String.fromCharCode(e.which).toLowerCase(); | |||
| const itemsOfChar = char !== '' && | |||
There was a problem hiding this comment.
Array.from is is not supported in IE and also does not get transpiled. It would require a polyfill.
src/Dropdown.js
Outdated
| @@ -132,23 +132,32 @@ class Dropdown extends React.Component { | |||
| const disabledClass = mapToCssModules('disabled', this.props.cssModule); | |||
|
|
|||
| const items = container.querySelectorAll(`.${menuClass} .${itemClass}:not(.${disabledClass})`); | |||
| const char = String.fromCharCode(e.which).toLowerCase(); | |||
| const itemsOfChar = char !== '' && | |||
| Array.from(items).filter(item => | |||
There was a problem hiding this comment.
charAt or direct index access would have better performance
src/Dropdown.js
Outdated
| if (items[i] === e.target) { | ||
| index = i; | ||
| break; | ||
|
|
There was a problem hiding this comment.
If char is an empty string itemsOfChar will be false and this will throw an error.
monteith
commented
Aug 4, 2018
src/__tests__/Dropdown.spec.js
Outdated
| @@ -452,7 +452,7 @@ describe('Dropdown', () => { | |||
|
|
|||
| expect(Dropdown.prototype.toggle.mock.calls.length).toBe(0); | |||
|
|
|||
| wrapper.find('#first').hostNodes().simulate('keydown', { which: 52 }); | |||
| wrapper.find('#dropdown').hostNodes().simulate('keydown', { which: 52 }); | |||
There was a problem hiding this comment.
This test doesn't work when we trigger keydown events directly on the dropdown items, but I'm unable to actually replicate that scenario from my browser. It appears to me like this test is a more accurate representation of a user interaction. And it makes the tests pass. Of course, I could be wrong! 😄
TheSharpieOne
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1156