Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear timers on component unmount #1180

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Clear timers on component unmount #1180

merged 1 commit into from
Aug 20, 2018

Conversation

leonovalex
Copy link
Contributor

@leonovalex leonovalex commented Aug 18, 2018 •
edited
Loading

Clear timers on component unmount to avoid setting state after lifecycle ends

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@TheSharpieOne TheSharpieOne merged commit 9fea409 into reactstrap:master Aug 20, 2018
@leonovalex leonovalex deleted the times_on_unmount branch August 23, 2018 16:11
@TheSharpieOne TheSharpieOne mentioned this pull request Oct 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leonovalex @TheSharpieOne