-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Button): add close icon support (reactstrap/reactstrap#1182) #1206
feat(Button): add close icon support (reactstrap/reactstrap#1182) #1206
Conversation
Sorry for the delay, but what do you think about defaulting |
I think that is a great idea! I'll update the pr shortly.
|
ac32c58
to
9c66e7a
Compare
Pending checks, I've added the default children to the commit. If anything else needs fixing, I would be happy to see to it tomorrow. @TheSharpieOne |
Add support for close icon utility from Bootstrap 4. This commit adds an optional boolean property, 'close', to the Button component. Applying the close prop will render the Close icon utility from Bootstrap 4. Update documentation on the Button component to demonstrate usage of the close prop. Closes reactstrap#1182
7184988
to
e406d1b
Compare
…o support-close-icon-util
…strap into support-close-icon-util
Fixed code linting error at line 62. Addd a space after `if`.
Thanks for the PR! |
This PR addresses #1182.
Add support for close icon utility from Bootstrap 4.
This commit adds an optional boolean property, 'close', to the
Button component. Applying the close prop will render the Close
icon utility from Bootstrap 4.
Update documentation on the Button component to demonstrate usage
of the close prop.
This is my first time submitting a PR. I welcome any constructive feedback you have to offer if you are reviewing this PR.
Closes #1182