Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tooltip): default value of trigger changed #1695

Merged
merged 1 commit into from
Nov 4, 2019
Merged

fix(Tooltip): default value of trigger changed #1695

merged 1 commit into from
Nov 4, 2019

Conversation

rodlukas
Copy link
Contributor

@rodlukas rodlukas commented Nov 4, 2019 •
edited
Loading

New value hover focus is also used as the default value by bootstrap, setting the trigger value to previous value click hover focus causes problems on iOS (resolves issue #1676)

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Resolves #1676

@rodlukas
Tooltip trigger default value changed
3a2a7f0 
New value `hover focus` is also used as the default value by bootstrap, setting the trigger value to previous value `click hover focus` causes problems on iOS (resolves issue reactstrap#1676)
TheSharpieOne
TheSharpieOne approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@TheSharpieOne TheSharpieOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really validate that it fixes the iOS issue, but this doesn't break the existing usage and better lines up with bootstrap... so LGTM

@TheSharpieOne TheSharpieOne merged commit ae48d93 into reactstrap:master Nov 4, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 20, 2020
Closed
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSharpieOne TheSharpieOne TheSharpieOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip on iOS opens only after double tap
2 participants
@rodlukas @TheSharpieOne