Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Carousel): Add touch swipe support #1731

Merged
merged 5 commits into from Dec 20, 2019
Merged

feat(Carousel): Add touch swipe support #1731

merged 5 commits into from Dec 20, 2019

Conversation

Ashniu123
Copy link
Contributor

@Ashniu123 Ashniu123 commented Dec 16, 2019 •
edited

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

#1696

@TheSharpieOne
Copy link
Member

This looks good, but can we expose a prop to control if touch is enabled (similar to bootstrap). It can default to true.
Also, can we check the y-axis to not trigger the swipe if y-movement is more than x-movement (for people just swiping to scroll up/down)

Ashniu123 and others added 4 commits December 16, 2019 22:35
@Ashniu123
fix(Carousel): prefer scrolling to slide change if movement in Y is g…
2ff5225 
…reater than X
@Ashniu123
feat(Carousel): allow disabling touch gestures
f80a999
@TheSharpieOne
Update Carousel.js
115e9ea 
Do not store touch points in state since they are not rendered and do not need to trigger a re-render.
@TheSharpieOne
Update Carousel.js
ecb121a
@Ashniu123
Copy link
Contributor Author

Look good. Merge into master and close issue?

@TheSharpieOne TheSharpieOne merged commit 8a12330 into reactstrap:master Dec 20, 2019
@TheSharpieOne TheSharpieOne mentioned this pull request Jan 15, 2020
Merged
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Merged
This was referenced Mar 29, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ashniu123 @TheSharpieOne