fix: remove aria-hidden attribute from tooltips and popovers #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
monicahung
commented
Jan 10, 2020
•
monicahung
commented
- Bug fix
- New feature
- Chore
- Breaking change
- There is an open issue which this change addresses
- I have read the CONTRIBUTING document.
- My commits follow the Git Commit Guidelines
- My code follows the code style of this project.
- My change requires a change to the documentation.
-
- I have updated the documentation accordingly.
- I have added tests to cover my changes.
- All new and existing tests passed.
Change tooltips and popovers from having `aria-hidden` set to true to make the attribute unspecified. Make content in popovers accessible to assistive technologies.
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.