Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DropdownItem): Add support for .dropdown-item-text #1971

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

kyletsang
Copy link
Member

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Adds support for plaintext menu items.

From Bootstrap docs:

You can also create non-interactive dropdown items with .dropdown-item-text. Feel free to style further with custom CSS or text utilities.

https://getbootstrap.com/docs/4.5/components/dropdowns/#menu-items

@kyletsang
Copy link
Member Author

Hey @TheSharpieOne, unrelated side note, but if you’d like, I can help out with library maintenance. We still use this in my company, and I do want to make some improvements (possibly bring typescript defs in-house among other things).

@kyletsang kyletsang merged commit c41b172 into reactstrap:master Oct 7, 2020
@kyletsang kyletsang deleted the feat/dropdown-item-text branch October 7, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant