Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add typescript definitions #1976

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

kyletsang
Copy link
Member

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Definitions were copied from DefinitelyTyped and updated with PRs that have yet to be merged over there.

The build process copies the dts files into es/lib output folders.

You can test the types by running npm run dtslint.

@kyletsang kyletsang merged commit 2a47626 into reactstrap:master Oct 19, 2020
@kyletsang kyletsang deleted the feat/typescript-types branch October 19, 2020 16:56
@ghost
Copy link

ghost commented Nov 2, 2020

Does this mean what depending on DefinitelyTyped is not necessary anymore and types here will be 100% correct ?

@kyletsang
Copy link
Member Author

@Hansikk correct, going forward you won't need to import from DT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants