Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to CSSModule #2007

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Fix reference to CSSModule #2007

merged 1 commit into from
Nov 2, 2020

Conversation

jmandel
Copy link
Contributor

@jmandel jmandel commented Nov 2, 2020

The 8.7.0 release has a broken import of CSSModuile at https://github.com/reactstrap/reactstrap/blob/8.7.0/types/lib/Toast.d.ts#L2

  • Bug fix

@kyletsang kyletsang merged commit 54afca4 into reactstrap:master Nov 2, 2020
@kyletsang
Copy link
Member

Thanks

@jmandel jmandel deleted the patch-1 branch November 2, 2020 20:23
@jmandel
Copy link
Contributor Author

jmandel commented Nov 2, 2020

Sure! (Would be great if there were tests to automatically check validity of these definitions -- I wasn't sure where/how you'd want to add this though.)

@kyletsang
Copy link
Member

We have a test file reactstrap-tests.tsx inside the types folder where you can add type tests.

Unfortunately this bug one slipped through due to the duplicate index.d.ts in the types folder that contained another CSSModule def. I think I had this dupe file in there to get the dtslint to work properly. Going to look into cleaning this up to prevent this from slipping again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants