Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Fix Col and Input types #2008

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

kyletsang
Copy link
Member

  • Adds missing cssModule for Col
  • Fixes innerRef for Input to allow HTMLTextAreaElement
  • Removes CSSModule export in root index.d.ts

Removing CSSModule in root index.d.ts prevents mistakes like #2007 from happening again. The index.d.ts is still needed in the root folder to make dtslint run.

Also fixes #1455

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Adds missing cssModule for Col
- Fixes innerRef for Input to allow HTMLTextAreaElement
- Removes CSSModule export in root index.d.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input type="textarea" with innerRef
1 participant