Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ListInline): add List and ListInlineItem components #2033

Merged
merged 15 commits into from
Dec 14, 2020
Merged

feat(ListInline): add List and ListInlineItem components #2033

merged 15 commits into from
Dec 14, 2020

Conversation

johnathanmiller
Copy link
Contributor

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

#2031

@kyletsang kyletsang linked an issue Dec 9, 2020 that may be closed by this pull request
List inline #2031
Closed
kyletsang
kyletsang requested changes Dec 9, 2020
View reviewed changes
src/ListInlineItem.js Outdated Show resolved Hide resolved
src/ListInline.js Outdated Show resolved Hide resolved
@johnathanmiller johnathanmiller changed the title feat(ListInline): add ListInline and ListInlineItem components feat(ListInline): add List and ListInlineItem components Dec 10, 2020
@johnathanmiller
Copy link
Contributor Author

Summary of changes:

  • Renamed ListInline to List.
  • List now accepts a prop of type
  • List and ListInlineItem both accept ref
  • Docs now have a List page which contains both unstyled and inline list examples
  • Updated tests

kyletsang
kyletsang reviewed Dec 10, 2020
View reviewed changes
src/List.js Outdated Show resolved Hide resolved
@kyletsang
Copy link
Member

Looks good. One final fix for the forwardRef for both components and we should be good to go.

kyletsang
kyletsang approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kyletsang kyletsang merged commit a97a834 into reactstrap:master Dec 14, 2020
@kyletsang kyletsang mentioned this pull request Dec 23, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Merged
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Merged
This was referenced Mar 29, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 13, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jan 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List inline
2 participants
@johnathanmiller @kyletsang