feat: add positionFixed prop to Tooltip and Popover #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
reviewed
Dec 21, 2020
| @@ -108,6 +108,7 @@ class PopperContent extends React.Component { | |||
| tag, | |||
| container, | |||
| modifiers, | |||
| positionFixed, | |||
There was a problem hiding this comment.
Let's add this to propTypes too
|
Added |
kyletsang
approved these changes
Dec 22, 2020
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-popper has a positionFixed prop that allows the popover itself to have the
position: fixedstyle, so that it doesn't flicker when applied to an element that itself is position-fixed. This change allows users of Tooltip/Popover components to specify this and pass it on to prevent flickering.