New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#1289): prevent error in Strict Mode #2672
Merged
illiteratewriter
merged 6 commits into
reactstrap:master
from
illiteratewriter:fix-warning-in-strict-mode
Mar 2, 2023
Merged
fix(#1289): prevent error in Strict Mode #2672
illiteratewriter
merged 6 commits into
reactstrap:master
from
illiteratewriter:fix-warning-in-strict-mode
Mar 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
illiteratewriter
commented
Dec 20, 2022
•
edited
edited
- remove findDomNode error which was thrown for components using Fade.js file in ReactStrict mode
- Bug fix
- New feature
- Chore
- Breaking change
- There is an open issue which this change addresses
- I have read the CONTRIBUTING document.
- My commits follow the Git Commit Guidelines
- My code follows the code style of this project.
- My change requires a change to the documentation.
- I have updated the documentation accordingly.
- My change requires a change to Typescript typings.
- I have updated the typings accordingly.
- I have added tests to cover my changes.
- All new and existing tests passed.
- remove findDomNode error which was thrown for components using Fade.js file in ReactStrict mode
…ter/reactstrap into fix-warning-in-strict-mode
aaronmars
approved these changes
Feb 13, 2023
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.