Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2660): dropdown closes for complex children #2673

Merged
merged 3 commits into from Mar 2, 2023

Conversation

illiteratewriter
Copy link
Member

@illiteratewriter illiteratewriter commented Dec 20, 2022

  • fix issue where if children of dropdown toggle where not simple strings the dropdown would remain open
  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- fix issue where if children of dropdown toggle where not simple
strings the dropdown would remain open
@frankybboy96
Copy link

Any update on this? is this gonna be reviewed eventually, we've got the problem since we're using icons instead of text in some of our dropdown.. this fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants