Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2431 remove margin bottom form group v2 #2676

Merged

Conversation

AJax2012
Copy link
Contributor

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Relates to issue #2431. Adds noMargin property to FormGroup to allow removal of mb-3 class.

@goncharov
Copy link

@illiteratewriter @davidacevedo @AJax2012 Hey guys, can we see this one merged?

@AJax2012
Copy link
Contributor Author

AJax2012 commented Jun 19, 2023

No complains from me - but I don't have the ability to do so. However, apparently this has sat long enough that there are once again merge conflicts... I'll try to resolve those today.

@AJax2012
Copy link
Contributor Author

@goncharov This should be good to merge now.

@illiteratewriter @davidacevedo

@aaronmars aaronmars merged commit b43aa3b into reactstrap:master Jul 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants