-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#2662): remove many instances of default props #2752
fix(#2662): remove many instances of default props #2752
Conversation
I'm aware this doesn't fully address |
Hope it can be merged ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool for removing the defaultProps.
Thank you so much for the PR. I added comments earlier instead of a review. Sorry about that. Also, Reactstrap uses |
7a7f2b4
to
1e6c62f
Compare
@illiteratewriter thanks for the feedback. I have responded to them all. Happy to discuss any further :) |
11aeecc
to
53aadfd
Compare
53aadfd
to
9e14877
Compare
@illiteratewriter Hi, what's next? Do you plan to merge this PR? |
Partially fixes #2662