feat(Uncontrolled): add various uncontrolled components #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddywashere
reviewed
Jan 26, 2017
| } | ||
| } | ||
|
|
||
| SimpleComponent.displayName = key; |
TheSharpieOne
force-pushed
the
feature/uncontrolled
branch
from
229655f
to
4cc1640
Compare
|
Thanks! It kind of highlights the api differences between the components added and ones that could be added, Popover & Modal. I don't think it would be practical to have Tooltip require onMouseEnter, onMouseLeave + using toggle and isOpen on the target component. Maybe Tooltip could have a prop to enable current auto hover events and Popover could have a similar prop to enable auto hover handlers. I'll create an issue to track/discuss it. Thanks again! |
This was referenced Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alert(dismissible),ButtonDropdown,Dropdown,NavDropdown, andTooltipnow have uncontrolled counterpartsUncontrolledAlert,UncontrolledButtonDropdown,UncontrolledDropdown,UncontrolledNavDropdown, andUncontrolledTooltiprespectfully.These uncontrolled components can be used without the user/developer needing to control the state. They will manage their own state of when to show/hide based on the common use-case. The original components are still there for the more advanced use and non-common use-cases.
The goal of these new components is to make it easier for out-of-the-box development.
Documentation for the various components have been added to the end of each of their respective pages.