Add toggle switch to DropdownItem to allow conditional toggle #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddywashere
reviewed
Mar 31, 2017
| @@ -40,7 +43,9 @@ class DropdownItem extends React.Component { | |||
| this.props.onClick(e); | |||
| } | |||
|
|
|||
| this.context.toggle(); | |||
| if (this.props.toggle) { | |||
| this.context.toggle(); | |||
There was a problem hiding this comment.
Rethinking this, bool seems fine for preventing toggle. But, if a function is passed to toggle prop, we should probably call that instead of context. That can be an enhancement pr that should be backwards compatible.
There was a problem hiding this comment.
I completely agree, I'll do this and create a new PR as soon as I have some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current master the dropdown toggle is called whenever a DropdownItem is clicked. This interferes with using the Dropdown for multiselect purposes. My proposal adds a toggle switch that defaults to true, so that the current default behaviour stays the same, but an optional toggle prop can be set to {false} which then skips the call to this.context.toggle and allows the menu to stay open on DropdownItem onClick.