Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): Add class form-control-label to Label components #452

Merged
merged 1 commit into from Jun 27, 2017
Merged

fix(Modal): Add class form-control-label to Label components #452

merged 1 commit into from Jun 27, 2017

Conversation

matthewheck
Copy link
Contributor

Adds the form-control-label class to the Label component when the component is not used with a check or column prop. This class will be added in plain Label components and also inline Label components.

I might also suggest keeping an eye on twbs/bootstrap#22173 moving forward in case further clarification on the distinction between col-form-label and form-control-label is provided

This resolves #451.

@eddywashere eddywashere merged commit 2e86132 into reactstrap:master Jun 27, 2017
@eddywashere eddywashere mentioned this pull request Jun 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSharpieOne TheSharpieOne TheSharpieOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label component missing form-control-label class
3 participants
@matthewheck @TheSharpieOne @eddywashere