New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag attribute breaks <Button disabled> style #562

Closed

ex-tag opened this issue Sep 3, 2017 · 1 comment

ex-tag commented Sep 3, 2017 •

edited

import { Button } from 'reactstrap';
import { Link } from 'react-router-dom';

<Button role="button" tag={Link} to="/endpoint" disabled>Click Me</Button>

This code breaks the "not-allowed" cursor that normally exists on a disabled Bootstrap button.

The text was updated successfully, but these errors were encountered:

ex-tag changed the title ~~Tag attribute breaks disabled <button> style~~ Tag attribute breaks <Button disabled> style

Member

TheSharpieOne commented Sep 15, 2017

You would need to take this issue up with bootstrap but bootstrap has done this intentionally, reactstrap doesn't do any styling.
Bootstrap PR which removed the style: twbs/bootstrap#22403
Bootstrap issue which asked why (and has a work-around): twbs/bootstrap#23334
Bootstrap docs, which match reactstrap's for this: https://getbootstrap.com/docs/4.0/components/buttons/#disabled-state

I'm closing this as there is nothing reactstrap can do since it is inline with what bootstrap is doing.

TheSharpieOne closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment