Adding className to carousel components #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses Issue 69 - Adds support for carousel components to accept the className prompt - Adds an example showing use of custom carousel tag and className
TheSharpieOne
requested changes
Nov 14, 2017
src/Carousel.js
Outdated
| @@ -190,13 +191,15 @@ Carousel.propTypes = { | |||
| // controls whether the slide animation on the Carousel works or not | |||
| slide: PropTypes.bool, | |||
| cssModule: PropTypes.object, | |||
| className: PropTypes.string, | |||
| }; | |||
|
|
|||
| Carousel.defaultProps = { | |||
| interval: 5000, | |||
| pause: 'hover', | |||
| keyboard: true, | |||
| slide: true, | |||
There was a problem hiding this comment.
Don't think you meant to put this here
src/CarouselCaption.js
Outdated
| 'carousel-caption', | ||
| 'd-none', | ||
| 'd-md-block' | ||
| 'd-md-block', |
There was a problem hiding this comment.
Idk if comma dangle in a function call is a thing
mkalish
commented
Nov 14, 2017
| .custom-tag { | ||
| max-width: 100%px; |
There was a problem hiding this comment.
Good catch @TheSharpieOne
mkalish
commented
Nov 14, 2017
| @@ -76,14 +76,13 @@ class Example extends Component { | |||
|
|
|||
| return ( | |||
| <div> | |||
| <style dangerouslySetInnerHTML={{__html: ` | |||
| <style>{` | |||
There was a problem hiding this comment.
This is much better than what I had... I have a few other places to change now.
|
Please excuse the uninformed question. In particular, resizing it so that the image is responsive as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #669