feat(Popover/Tooltip): add ability to hide arrow (#814) #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supergibbs
reviewed
Feb 8, 2018
src/PopperContent.js
Outdated
| @@ -162,7 +165,7 @@ class PopperContent extends React.Component { | |||
| return ( | |||
| <ReactPopper modifiers={extendedModifiers} {...attrs} component={tag} className={popperClassName}> | |||
| {children} | |||
| <Arrow className={arrowClassName} /> | |||
| {hideArrow ? null : <Arrow className={arrowClassName} />} | |||
There was a problem hiding this comment.
This syntax is a little nicer {!hideArrow && <Arrow className={arrowClassName} />}. Looks good otherwise!
There was a problem hiding this comment.
Okay, that was a dilemma for me too. I will fix it.
supergibbs
approved these changes
Feb 8, 2018
TheSharpieOne
approved these changes
Feb 9, 2018
jlaramie
pushed a commit
to jlaramie/reactstrap
that referenced
this pull request
Mar 9, 2018
…actstrap#815) feat(Popover/Tooltip): add ability to hide arrow (reactstrap#814)
This was referenced Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
hideArrowprop to Popover, Tooltip and PopperContent according to #814 .