Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactUnity polyfils are not loaded from Resources #73

Closed
Muchaszewski opened this issue Nov 28, 2022 · 4 comments
Closed

ReactUnity polyfils are not loaded from Resources #73

Muchaszewski opened this issue Nov 28, 2022 · 4 comments
Labels
external bug Bug is caused by an external source, Unity itself or another library
Milestone

Comments

@Muchaszewski
Copy link
Contributor

Muchaszewski commented Nov 28, 2022

Unity in version 2020.3.33 is unable to load js files from polyfills, as they are just not found. Unity Resources class cannot find them as valid extensions.

To fix that I needed to manually copy the files and change the extensions of those files to txt.

image

For compatibility reasons, I would keep them as txt in the final package. Either by making them permanently txt or by adding CI pipeline to that to retain the highlights in vscode and others.

@KurtGokhan
Copy link
Member

If Unity can't find .js files in Resources, that will be a problem not only for polyfills, but also for other cases too (after build for example). I don't remember this issue in any unity versions. Might be a bug in Unity 2020.3.33. I will need to investigate.

@Muchaszewski
Copy link
Contributor Author

You are right and I'm dumb :| This is not an issue in 2020 but in 2022.2.0b15. Just double-checked.

You might be right as this can by only unity version thing

@KurtGokhan
Copy link
Member

I have encountered similar bugs in Unity beta versions. Thanks for reminding though. 2022.2 will be added to tests in CI once it is released.

@KurtGokhan KurtGokhan added the external bug Bug is caused by an external source, Unity itself or another library label Nov 29, 2022
@KurtGokhan KurtGokhan added the pending fix This issue is already fixed, but not released yet. label Dec 17, 2022
@KurtGokhan KurtGokhan added this to the v0.14.0 milestone Dec 26, 2022
@KurtGokhan KurtGokhan removed the pending fix This issue is already fixed, but not released yet. label Jan 16, 2023
@KurtGokhan
Copy link
Member

Fixed in v0.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external bug Bug is caused by an external source, Unity itself or another library
Projects
None yet
Development

No branches or pull requests

2 participants