Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the verbose name of the action #11

Closed
agjohnson opened this issue Aug 18, 2022 · 4 comments
Closed

Change the verbose name of the action #11

agjohnson opened this issue Aug 18, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@agjohnson
Copy link

Multiple times now, I've surprised myself and tried to click the check for the PR docs links action in the PR list of checks. Apparently I'm confused by how prominent the check looks, but of course the "details" link for that check does not do what you expect.

I'm actually not even sure where this name comes from, but just assuming its centrally configured here somehow.

So, I would say this first check is more prominent that our own RTD build check:

sorry, github is broken

And even though our check has our icon in that list, I still somehow want to click the first check, the check for the links. So, if I am actively/subconsciously doing this as someone familiar with RTD, there must be others that would notice this.

Looking more at this, "Read the Docs" looks more official than "docs/readthedocs.com:...", and the first link mentions "pull request preview". Though the links are in the PR description, users are probably still used to clicking the check detail links, so would be bound to hit this confusion.

This is a case where showing this action in the PR action list is probably a worse scenario, but that's up to GitHub to deal with.

But because we shouldn't expect users to interact with this particular action in the list of checks, I think a much less prominent name would at least not overwhelm our actual PR check.

We could follow the naming scheme used in other checks, this is definitely less prominent and doesn't make me want to keep clicking it.

great job github

@humitos
Copy link
Member

humitos commented Aug 18, 2022

I'm actually not even sure where this name comes from, but just assuming its centrally configured here somehow.

The names comes from https://github.com/readthedocs/actions/blob/main/.github/workflows/readthedocs-preview.yaml#L1

It's a combination of:

  • the name of the action
  • the name of the job
  • the event registered

So, we can update our example to make it simpler --but it's per-repository, so it won't change the name from repositories already using the action.

Docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#name

@humitos humitos added the enhancement New feature or request label Aug 18, 2022
humitos added a commit that referenced this issue Aug 18, 2022
humitos added a commit that referenced this issue Aug 18, 2022
@humitos
Copy link
Member

humitos commented Aug 18, 2022

I tweaked it a little following your suggestion and ended up with the following (see #13):

Screenshot_2022-08-18_10-45-23

If you are happy with it, we should change the documentation at https://github.com/readthedocs/actions/tree/main/preview#how-to-use-it as well. Let me know!

@agjohnson
Copy link
Author

Ah yeah, looks much better! I don't think I'd click on that first

@humitos
Copy link
Member

humitos commented Aug 18, 2022

Cool! Closed by f132761

@humitos humitos closed this as completed Aug 18, 2022
humitos added a commit that referenced this issue Jan 30, 2023
humitos added a commit that referenced this issue Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants