Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: re-add tests for minor versions of Sphinx #138

Closed
humitos opened this issue Feb 23, 2021 · 1 comment
Closed

Tests: re-add tests for minor versions of Sphinx #138

humitos opened this issue Feb 23, 2021 · 1 comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code Sprintable Small enough to sprint on

Comments

@humitos
Copy link
Member

humitos commented Feb 23, 2021

When we migrated to Circle CI in #130 we removed tests for different Sphinx minor versions and we are only testing the latest on major ones. However, Sphinx has break compatibility between minor versions and there are things that work different. Example https://github.com/rtfd/sphinx-notfound-page/blob/f30850e4a648e4490824499671f72522e41c66fa/tests/test_urls.py#L406-L409

So, I want to bring back them. I prefer to break the code on CI than receive a user report.
@humitos humitos added Improvement Minor improvement to code Good First Issue Good for new contributors Accepted Accepted issue on our roadmap Sprintable Small enough to sprint on labels Feb 23, 2021
@humitos humitos changed the title Tests: re-add tests for minor version of Sphinx Tests: re-add tests for minor versions of Sphinx Feb 23, 2021
@humitos
Copy link
Member Author

humitos commented Aug 24, 2023

We are testing only 5, 6, 7 and latest.

@humitos humitos closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code Sprintable Small enough to sprint on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@humitos