Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation_depth in html_theme_options is ignored with Sphinx >=6.0 #1418

Closed
akiyks opened this issue Jan 22, 2023 · 4 comments
Closed

navigation_depth in html_theme_options is ignored with Sphinx >=6.0 #1418

akiyks opened this issue Jan 22, 2023 · 4 comments
Labels
Bug A bug Needed: replication Bug replication is required

Comments

@akiyks
Copy link

akiyks commented Jan 22, 2023

Problem

I'm testing RTD theme v1.2.0rc3 with Sphinx 6.1.3.
In the sidebar, navigation depth becomes 2 regardless of the setting of navigation_depth in conf.py
I see the same issue with Sphinx >=6.0.0.

RTD theme v1.2.0rc3 with Sphinx 5.3.0 works as expected.

I can't tell whether this is regression in Sphinx >=6.0 or RTD theme needs some adjustment for Sphinx >=6.0.

Can you please look into this?

Reproducible Project

sphinx_rtd_theme's docs/.

Run "make html" under docs/ and see sidebar's behavior in the generated html.

Environment Info

  • Python Version: Python 3.9.2
  • Sphinx Version: 6.1.3 (since 6.0.0)
  • RTD Theme Version: v1.2.0rc3
@akiyks akiyks added Bug A bug Needed: replication Bug replication is required labels Jan 22, 2023
@akiyks
Copy link
Author

akiyks commented Feb 7, 2023

RTD Theme v1.2.0rc4 has resolved this issue.
Closing now.

Thanks!

@akiyks akiyks closed this as completed Feb 7, 2023
@benjaoming
Copy link
Contributor

Thanks for confirming that it's fixed!

This sounds like a variation of a jQuery issue (#1420 ), whereby SNI blocked loading jQuery on local builds? Were you looking at file:// in your browser?

@akiyks
Copy link
Author

akiyks commented Feb 7, 2023

Were you looking at file:// in your browser?

Yes, that's exactly what I was doing!

@benjaoming
Copy link
Contributor

Got it! Thanks for helping to resolve the issue fully 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Needed: replication Bug replication is required
Projects
None yet
Development

No branches or pull requests

2 participants