Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font awesome links in badge_only.css are broken #359

Closed
toolness opened this issue Feb 10, 2017 · 5 comments
Closed

Font awesome links in badge_only.css are broken #359

toolness opened this issue Feb 10, 2017 · 5 comments

Comments

@toolness
Copy link

I stumbled into this when attempting to add a generated site using sphinx_rtd_theme to my Django project's static files dir; its ManifestFileStorage throws errors if CSS files contain URLs to non-existent files, and it seems this is the case with the static/css/badge_only.css file, which references the following URL:

../font/fontawesome_webfont.eot

However, the project's font directory is called fonts (plural) and the file it's looking for has a hyphen instead of an underscore in it (it's called fontawesome-webfont.eot). This is also the case with the .woff, .ttf, and .svg versions of the file.

@toolness
Copy link
Author

For what it's worth, I'm interested in submitting a PR to fix this, just let me know!

Right now I'm working around it on my end by running the following after building the docs:

sed -i.bak 's/font\/fontawesome_/fonts\/fontawesome-/g' \
  $(BUILDDIR)/html/_static/css/badge_only.css

@Blendify
Copy link
Member

I can confirm this issue also.

@Blendify
Copy link
Member

Blendify commented Mar 4, 2017

@toolness I can also make a fix for this but if you are still up for it go for it.

@toolness
Copy link
Author

toolness commented Mar 7, 2017

Woot thanks for fixing this @Blendify!

@Blendify
Copy link
Member

Blendify commented Mar 7, 2017

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants