Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks hashchange event if bound to window #1

Closed
RyanEwen opened this issue May 23, 2017 · 4 comments
Closed

Breaks hashchange event if bound to window #1

RyanEwen opened this issue May 23, 2017 · 4 comments
Assignees

Comments

@RyanEwen
Copy link

I just noticed that hashchange events no longer make it to my application if I initialize the plugin on 'window'.

It seems to be okay when using 'document', though.

@RyanEwen
Copy link
Author

Hmm it seems to break jquery draggable when on document now.

@RyanEwen
Copy link
Author

RyanEwen commented May 25, 2017

To clarify the issue, draggables will work once, and then stop working after that, but only when jquery.inactivity is present.

After more investigation it seems to be due to your clear function being called. If I remove that, it works fine. So then I added it back and added a namespace to each event name, but surprisingly this doesn't help.

@RyanEwen
Copy link
Author

Figured out the exact cause. If no custom event names are specified then clear unbinds all events by mistake. I am going to make a fork and fix this.

@kaparelos
Copy link
Owner

Thanks for reporting and fixing :)

@kaparelos kaparelos self-assigned this Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants