Fix bug where all events are unbound if no custom events provided. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 25, 2017 12:58
Add curly braces where missing. Clear event bindings after settings are created, to allow clearing custom events properly (fixes bug where all events are unbound).
|
Ping |
|
Thank you Ryan 👍 |
|
Actually this had some changes from my fork in it that are undesirable.. it changed the URL ref to your repo to my fork instead.. |
|
:(
…On Tue, 12 Sep 2017 at 21:02, Ryan Ewen ***@***.***> wrote:
Actually this had some changes from my fork in it that are undesirable..
it changed the URL ref to your repo to my fork instead..
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC7jEbvvLjqaoamB_ppmR8UGFNiG4_-5ks5shtVAgaJpZM4NmoRj>
.
|
|
Just the readme file.. I suggest reverting that change if you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace event bindings and triggered events.
Add curly braces where missing.
Clear event bindings after settings are created, to allow clearing custom events properly (fixes bug where all events are unbound).