Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core.cljs is overwritten by core.cljx #5

Closed
Frozenlock opened this issue Nov 21, 2014 · 6 comments
Closed

core.cljs is overwritten by core.cljx #5

Frozenlock opened this issue Nov 21, 2014 · 6 comments

Comments

@Frozenlock
Copy link
Contributor

I scratched my head for quite a while trying to understand why the compiled js wasn't the one in core.clj. Turns out there's a default core.cljx that's overwriting the file when generating the cljs version.

@yogthos
Copy link
Member

yogthos commented Nov 21, 2014

Sounds like the core.cljx could probably be removed entirely since it doesn't do anything useful.

@Frozenlock
Copy link
Contributor Author

Or perhaps just name it core2.cljx or something?

It's nice to have the .cljx file, because you immediately know where it's supposed to be without looking at your project.clj.

@yogthos
Copy link
Member

yogthos commented Nov 21, 2014

That's a good point, so possibly util.cljx or something then. :)

@yogthos
Copy link
Member

yogthos commented Nov 22, 2014

Ok renamed and pushed out a new template to clojars, I notice that I have to also run lein cljx explicitly I haven't looked hard to see if there's a way around that though.

On an unrelated note, are you still up for adding historian to the org? :)

@Frozenlock
Copy link
Contributor Author

Great, I'll close this issue then.

For Historian:
Am I, but I haven't received many criticisms (good or bad) on the issue.

@yogthos
Copy link
Member

yogthos commented Nov 22, 2014

ah I didn't notice the issue, I see Sean commented already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants