ReagentInput :ref broken

[Deraen]

42ba166 broke using :ref attribute with input elements. This is because :ref attribute is always overriden for these elements:

reagent/src/reagent/impl/template.cljs

Line 186 in 42ba166

($! :ref #($! this :cljsInputElement %1))))))

If the code keeps on going using :ref callback, it must keep track of the original function and call that. If ref callback is used, string ref can never be supported here, but maybe that is not a problem as those haven't really worked with Reagent anyway.

[holmsand]

Great catch! The patch looks good too as far as I can tell – I'll put that into a 0.6.1. Thanks!

[pesterhazy]

FWIW I do use string based :refs for input elements. Mostly for historical reasons -- ref callbacks (which are superior) didn't exist a while ago.

[pesterhazy]

BTW I use (aget (.-refs (r/current-component)) "my-input") to get the backing instance of the component

[Deraen]

Check PR #260, looks like ReagentInput will be using findDOMNode so it doesn't need to touch refs at all.