fix: Fix Dialog closing on Firefox when the window loses focus and …

…get focused again (#620) Closes #619
ariakit · Apr 15, 2020 · 7c3119d · 7c3119d
1 parent db71535
commit 7c3119d
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/packages/reakit/src/Dialog/__utils/useHideOnClickOutside.ts b/packages/reakit/src/Dialog/__utils/useHideOnClickOutside.ts
@@ -47,8 +47,8 @@ export function useHideOnClickOutside(
       // triggered the mousedown event. This prevents the dialog from closing
       // by dragging the cursor (for example, selecting some text inside the
       // dialog and releasing the mouse outside of it).
-      if (mouseDownRef.current === event.target && options.hide) {
-        options.hide();
+      if (mouseDownRef.current === event.target) {
+        options.hide?.();
       }
     },
     options.visible && options.hideOnClickOutside
@@ -59,7 +59,12 @@ export function useHideOnClickOutside(
     disclosuresRef,
     nestedDialogs,
     "focus",
-    options.hide,
+    (event) => {
+      // Fix for https://github.com/reakit/reakit/issues/619
+      if (event.target !== getDocument(dialogRef.current)) {
+        options.hide?.();
+      }
+    },
     options.visible && options.hideOnClickOutside
   );
 }