Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Composite on IE11 #609

Merged
merged 2 commits into from
Apr 6, 2020
Merged

fix: Fix Composite on IE11 #609

merged 2 commits into from
Apr 6, 2020

Conversation

diegohaz
Copy link
Member

@diegohaz diegohaz commented Apr 6, 2020

This PR fixes several issues with Composite and its derivative components on IE11, mostly related to the way events were created and fired. IE11 doesn't support event constructors.

This also makes sure that intermediate focus/blur events will be ignored for consistency between roving tabindex and aria-activedescendant approaches.

Does this PR introduce a breaking change?

No

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da87622:

Sandbox Source
heuristic-lehmann-ketc0 Configuration

@ariakit-bot
Copy link

ariakit-bot commented Apr 6, 2020

Deploy preview for reakit ready!

Built with commit da87622

https://deploy-preview-609--reakit.netlify.com

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #609 into master will decrease coverage by 0.54%.
The diff coverage is 82.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   95.64%   95.10%   -0.55%     
==========================================
  Files         122      123       +1     
  Lines        2089     2144      +55     
  Branches      622      633      +11     
==========================================
+ Hits         1998     2039      +41     
- Misses         91      105      +14     
Impacted Files Coverage Δ
packages/reakit/src/Tabbable/Tabbable.ts 88.33% <ø> (ø)
...rc/Composite/__utils/getNextActiveElementOnBlur.ts 66.66% <66.66%> (ø)
packages/reakit/src/Menu/MenuItem.tsx 82.97% <70.00%> (-1.81%) ⬇️
packages/reakit/src/Composite/Composite.ts 89.16% <78.84%> (-8.34%) ⬇️
packages/reakit/src/Composite/CompositeItem.ts 90.43% <100.00%> (+0.71%) ⬆️
...eakit/src/Composite/__utils/findEnabledItemById.ts 100.00% <100.00%> (ø)
packages/reakit/src/Radio/Radio.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417b3b3...da87622. Read the comment docs.

@diegohaz diegohaz merged commit 555b931 into master Apr 6, 2020
@diegohaz diegohaz deleted the fix/composite-on-ie11 branch April 6, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants