Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Checkbox activating twice on space key on Firefox #625

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

diegohaz
Copy link
Member

Closes #368

The Clickable component wasn't considering inputs, so the space key up was triggering another click on the checkbox.

I can't write a test for this because it checks for event.isTrusted, and, on tests, this is always false.

Does this PR introduce a breaking change?

No

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1abf62:

Sandbox Source
gallant-swanson-p3pz9 Configuration
Reakit Issue #368

@ariakit-bot
Copy link

ariakit-bot commented Apr 17, 2020

Deploy preview for reakit ready!

Built with commit d1abf62

https://deploy-preview-625--reakit.netlify.app

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #625 into master will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   95.56%   95.36%   -0.21%     
==========================================
  Files         121      121              
  Lines        2369     2374       +5     
  Branches      673      677       +4     
==========================================
  Hits         2264     2264              
- Misses        105      110       +5     
Impacted Files Coverage Δ
packages/reakit/src/Clickable/Clickable.ts 86.95% <0.00%> (-10.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b70f43...d1abf62. Read the comment docs.

@diegohaz
Copy link
Member Author

Looks like it's fixed on the CodeSandbox. @tom-sherman, could you please take a look?

Copy link
Member

@tom-sherman tom-sherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@diegohaz diegohaz merged commit c4d5961 into master Apr 17, 2020
@diegohaz diegohaz deleted the fix/checkbox-on-firefox branch April 17, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox on Firefox when using keyboard checks and unchecks immediately
3 participants