feat: Hide Tooltip when pressing Escape
#629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d96e8ac:
|
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 95.60% 95.61% +0.01%
==========================================
Files 121 122 +1
Lines 2368 2374 +6
Branches 672 674 +2
==========================================
+ Hits 2264 2270 +6
Misses 104 104
Continue to review full report at Codecov.
|
|
Deploy preview for reakit ready! Built with commit 1cb31c4 |
|
Deploy preview for reakit ready! Built with commit d96e8ac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a global event handler that hides all tooltips if Escape is pressed.
Does this PR introduce a breaking change?
No. This is part of the WAI-ARIA recommendations for tooltips.