Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix blur/focus events order on Tabbable on Safari and Firefox on MacOS #658

Merged
merged 3 commits into from May 29, 2020

Conversation

diegohaz
Copy link
Member

@diegohaz diegohaz commented May 29, 2020

When changing focus between tabbable elements on Safari and Firefox on MacOS, the blur event on the previous active element was being fired after the focus event on the next active element.

This PR waits for the blur event to happen on the active element before focusing the next element.

Does this PR introduce a breaking change?

No

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 90774c7:

Sandbox Source
tender-mcclintock-89272 Configuration

@ariakit-bot
Copy link

ariakit-bot commented May 29, 2020

Deploy preview for reakit ready!

Built with commit 90774c7

https://deploy-preview-658--reakit.netlify.app

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #658 into master will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   95.01%   95.59%   +0.58%     
==========================================
  Files         143      143              
  Lines        2606     2589      -17     
  Branches      742      734       -8     
==========================================
- Hits         2476     2475       -1     
+ Misses        130      114      -16     
Impacted Files Coverage Δ
packages/reakit/src/Tabbable/Tabbable.ts 92.98% <100.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e32db...90774c7. Read the comment docs.

@diegohaz diegohaz merged commit aad12ce into master May 29, 2020
@diegohaz diegohaz deleted the fix/safari-firefox-tabbable-focus branch May 29, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants