fix: add default empty value for items prop #934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an issue when I use the Menu from
reakit/Menu
to open a modal (code base from my company).When just after the click of an
MenuItem
(without any focus of elements on the opened modal) I press any key, the app crashes every time with this exception:Breakpoints:
The property
items
is alwaysundefined
. So, the.find
will crash. I've just added a default value for it to avoid this issue. I don't really know how this issue occurs because I can't reproduce it on my own.. but my company has this issue and we're struggling to deal with.Don't hesitate to tell me if I forgot something.
Thanks! ;-)