Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add button-as-link example #940

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

AlexMunoz
Copy link
Contributor

Hello @diegohaz
I want to contribute to Ariakit, so i made this simple example.

Example button as a link #939

Screenshots

image

@vercel
Copy link

vercel bot commented Dec 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

ariakit – ./

🔍 Inspect: https://vercel.com/ariakit/ariakit/Aj1p6GxqyxPyixpPLyTWP54AUytx
✅ Preview: https://ariakit-git-fork-alexmunoz-feat-button-as-link-ariakit.vercel.app

reakit – ./

🔍 Inspect: https://vercel.com/ariakit/reakit/3kJJaWyaXt966ZmiBfshFqp6cbYp
✅ Preview: Canceled

[Deployment for 3fd9148 canceled]

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AlexMunoz! This looks good, just made a suggestion.

I'll take a look at the build errors. It's not your fault.

@diegohaz diegohaz merged commit a23afc8 into ariakit:v2 Dec 7, 2021
@ariakit-bot
Copy link

Thanks a lot for contributing!

Based on our community guidelines, every person who has a PR of any kind merged is offered an invitation to the Reakit organization.

Should you accept, you'll get write access to the main repository and a fancy Reakit logo on your GitHub profile. You'll be able to label and close issues, create new branches etc. Make sure to read our contribution and community guidelines, which explains all of this in more detail.

If you have any questions, let me know!

@diegohaz diegohaz mentioned this pull request Dec 8, 2021
69 tasks
@diegohaz diegohaz changed the title feat: add example 'button as link' chore: Add button as link example Dec 8, 2021
@diegohaz diegohaz changed the title chore: Add button as link example chore: Add button as link example Dec 14, 2021
@diegohaz diegohaz changed the title chore: Add button as link example chore: Add button-as-link example Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants