Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add radio example #941

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Conversation

AlexMunoz
Copy link
Contributor

@AlexMunoz AlexMunoz commented Dec 9, 2021

Add radio example #939

@vercel
Copy link

vercel bot commented Dec 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

reakit – ./

🔍 Inspect: https://vercel.com/ariakit/reakit/ArdjsChqP4wi9LJFw9GG4u7Aqdet
✅ Preview: Canceled

[Deployment for e27cb9e canceled]

ariakit – ./

🔍 Inspect: https://vercel.com/ariakit/ariakit/nmVQKnRRzMrbvMpZmDmc4MxNoYTZ
✅ Preview: https://ariakit-git-fork-alexmunoz-feat-radio-example-ariakit.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #941 (15a500f) into v2 (2f7c6ca) will increase coverage by 2.29%.
The diff coverage is 100.00%.

❗ Current head 15a500f differs from pull request most recent head e27cb9e. Consider uploading reports for the commit e27cb9e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #941      +/-   ##
==========================================
+ Coverage   30.80%   33.09%   +2.29%     
==========================================
  Files         143      145       +2     
  Lines        4061     4061              
  Branches     1154     1153       -1     
==========================================
+ Hits         1251     1344      +93     
+ Misses       2809     2716      -93     
  Partials        1        1              
Impacted Files Coverage Δ
...ges/ariakit/src/radio/__examples__/radio/index.tsx 100.00% <100.00%> (ø)
packages/ariakit/src/dialog/dialog.tsx 53.79% <0.00%> (-6.97%) ⬇️
packages/ariakit/src/combobox/combobox-popover.ts 92.00% <0.00%> (-1.34%) ⬇️
...t/src/button/__examples__/button-as-link/index.tsx 100.00% <0.00%> (ø)
packages/ariakit/src/focusable/focusable.ts 75.42% <0.00%> (+0.57%) ⬆️
packages/ariakit/src/composite/composite.ts 90.37% <0.00%> (+0.74%) ⬆️
packages/ariakit/src/composite/composite-item.tsx 58.06% <0.00%> (+1.07%) ⬆️
packages/ariakit/src/composite/__utils.ts 71.59% <0.00%> (+3.40%) ⬆️
packages/ariakit/src/composite/composite-state.ts 79.79% <0.00%> (+14.14%) ⬆️
packages/ariakit/src/command/command.ts 86.84% <0.00%> (+14.47%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7c6ca...e27cb9e. Read the comment docs.

@AlexMunoz
Copy link
Contributor Author

AlexMunoz commented Dec 9, 2021

Hello @diegohaz, I'm working on the radio button example, but I am not sure about the tests, could you please take a look at it?

@AlexMunoz AlexMunoz mentioned this pull request Dec 9, 2021
69 tasks
Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexMunoz Tests look good! Great job! 👍

The only thing I'd change would be removing the describe function. With the granularity we already have with the separate examples, there's no need for nested tests.

packages/ariakit/src/radio/readme.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – reakit December 10, 2021 08:23 Inactive
@AlexMunoz AlexMunoz changed the title WIP - Ariakit: Add radio example Ariakit: Add radio example Dec 10, 2021
@AlexMunoz AlexMunoz marked this pull request as ready for review December 10, 2021 08:23
Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, @AlexMunoz! Thank you!

@diegohaz diegohaz merged commit e410f9d into ariakit:v2 Dec 12, 2021
@diegohaz diegohaz changed the title Ariakit: Add radio example chore: Add Radio example Dec 12, 2021
@diegohaz diegohaz changed the title chore: Add Radio example chore: Add radio example Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants