-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add radio
example
#941
Conversation
This pull request is being automatically deployed with Vercel (learn more). reakit – ./🔍 Inspect: https://vercel.com/ariakit/reakit/ArdjsChqP4wi9LJFw9GG4u7Aqdet [Deployment for e27cb9e canceled] ariakit – ./🔍 Inspect: https://vercel.com/ariakit/ariakit/nmVQKnRRzMrbvMpZmDmc4MxNoYTZ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## v2 #941 +/- ##
==========================================
+ Coverage 30.80% 33.09% +2.29%
==========================================
Files 143 145 +2
Lines 4061 4061
Branches 1154 1153 -1
==========================================
+ Hits 1251 1344 +93
+ Misses 2809 2716 -93
Partials 1 1
Continue to review full report at Codecov.
|
1851b75
to
15a500f
Compare
Hello @diegohaz, I'm working on the radio button example, but I am not sure about the tests, could you please take a look at it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexMunoz Tests look good! Great job! 👍
The only thing I'd change would be removing the describe
function. With the granularity we already have with the separate examples, there's no need for nested tests.
15a500f
to
e27cb9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, @AlexMunoz! Thank you!
Add radio example #939