-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add heading
example
#946
Conversation
This pull request is being automatically deployed with Vercel (learn more). ariakit – ./🔍 Inspect: https://vercel.com/ariakit/ariakit/BgxckM5TFiTRa4EXYUyMbHzPJV8b reakit – ./🔍 Inspect: https://vercel.com/ariakit/reakit/EromTBpZtyyyV6C6netAFBc6hBDk [Deployment for e73f329 canceled] |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## v2 #946 +/- ##
==========================================
+ Coverage 33.02% 33.39% +0.37%
==========================================
Files 145 146 +1
Lines 4061 4063 +2
Branches 1153 1153
==========================================
+ Hits 1341 1357 +16
+ Misses 2719 2705 -14
Partials 1 1
Continue to review full report at Codecov.
|
<HeadingLevel> | ||
<div role="heading-container" className="headingContainer"> | ||
<Heading>Lacus Et Semper Turpis Massa Commodo Cum</Heading> | ||
<p>Torquent penatibus ipsum nascetur cursus primis lobortis</p> | ||
<HeadingLevel> | ||
<Heading>Ac Nullam</Heading> | ||
<p>Volutpat metus id purus dignissim fusce Tellus egestas.</p> | ||
</HeadingLevel> | ||
<HeadingLevel> | ||
<Heading>Quis Placerat</Heading> | ||
<p>Platea justo lectus. Praesent. Et sodales pellentesque</p> | ||
</HeadingLevel> | ||
</div> | ||
</HeadingLevel> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! heading-container
is not a valid role though.
<HeadingLevel> | |
<div role="heading-container" className="headingContainer"> | |
<Heading>Lacus Et Semper Turpis Massa Commodo Cum</Heading> | |
<p>Torquent penatibus ipsum nascetur cursus primis lobortis</p> | |
<HeadingLevel> | |
<Heading>Ac Nullam</Heading> | |
<p>Volutpat metus id purus dignissim fusce Tellus egestas.</p> | |
</HeadingLevel> | |
<HeadingLevel> | |
<Heading>Quis Placerat</Heading> | |
<p>Platea justo lectus. Praesent. Et sodales pellentesque</p> | |
</HeadingLevel> | |
</div> | |
</HeadingLevel> | |
<div className="wrapper"> | |
<HeadingLevel> | |
<Heading>Lacus Et Semper Turpis Massa Commodo Cum</Heading> | |
<p>Torquent penatibus ipsum nascetur cursus primis lobortis</p> | |
<HeadingLevel> | |
<Heading>Ac Nullam</Heading> | |
<p>Volutpat metus id purus dignissim fusce Tellus egestas.</p> | |
</HeadingLevel> | |
<HeadingLevel> | |
<Heading>Quis Placerat</Heading> | |
<p>Platea justo lectus. Praesent. Et sodales pellentesque</p> | |
</HeadingLevel> | |
</HeadingLevel> | |
</div> |
.headingContainer{ | ||
@apply flex flex-col | ||
} | ||
|
||
h1{ | ||
@apply text-xl | ||
} | ||
|
||
h2{ | ||
@apply text-lg mt-4 | ||
} | ||
|
||
h3{ | ||
@apply text-base mt-4 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the wrapper class and some formatting. It would be awesome if prettier worked on CSS files.
.headingContainer{ | |
@apply flex flex-col | |
} | |
h1{ | |
@apply text-xl | |
} | |
h2{ | |
@apply text-lg mt-4 | |
} | |
h3{ | |
@apply text-base mt-4 | |
} | |
.wrapper { | |
@apply flex flex-col | |
} | |
h1 { | |
@apply text-xl | |
} | |
h2 { | |
@apply text-lg mt-4 | |
} | |
h3 { | |
@apply text-base mt-4 | |
} | |
render(<Example />); | ||
expect(getByRole("heading-container")).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
render(<Example />); | |
expect(getByRole("heading-container")).toMatchInlineSnapshot(` | |
const { container } = render(<Example />); | |
expect(container).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestions @diegohaz , made all the changes, one final time(hopefully :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thank you @saideepesh000!
Thanks a lot for contributing! Based on our community guidelines, every person who has a PR of any kind merged is offered an invitation to the Reakit organization. Should you accept, you'll get write access to the main repository and a fancy Reakit logo on your GitHub profile. You'll be able to label and close issues, create new branches etc. Make sure to read our contribution and community guidelines, which explains all of this in more detail. If you have any questions, let me know! |
Hai @diegohaz , I want to contribute to this project.
This PR adds
heading
example for #939